Commit Checklist

1 min read

a commit should pass this list before becoming a pull request


  • long classes
  • long functions
  • hardcoded variables
  • too many args
  • flags


  • errors handled properly


  • copy-paste
  • mixed styles
  • dead code
  • commented out lines


  • no tests
  • functions are hard to test


  • bad names


  • unnecessary complexity
  • functions should do one thing

May 29, 2020